Detect and recover from a bad service node state #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tewinget
force-pushed
the
stable-fix-reregister
branch
3 times, most recently
from
c5bd948 to
0102f59
Compare
If a node is deregistered while running (or is started before being registered), it can fail to properly connect to the network once registered (again). This does not *fix* that, but these symptoms should be sufficient to detect such a state and the node should recover upon restart.
tewinget
force-pushed
the
stable-fix-reregister
branch
from
0102f59 to
c03eed3
Compare
|
This has been carried as a patch in the debs for a couple months now, and I recently had a registration that reproduced the bug causing lokinet to get stuck with no peers, which successfully triggered this workaround and a restart that unstuck it without intervention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a node is deregistered while running (or is started before being registered), it can fail to properly connect to the network once registered (again). This does not fix that, but these symptoms should be sufficient to detect such a state, and the node should recover upon restart.